PKG -- [fcl] Default to localStorage #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f114a72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jribbink
changed the title
jribbink
commented
Sep 27, 2023
Comment on lines
-3
to
-14
| const getSessionStorage = () => { | ||
| try { | ||
| const SESSION_STORAGE = { | ||
| can: !isServerSide(), | ||
| get: async key => JSON.parse(sessionStorage.getItem(key)), | ||
| put: async (key, value) => sessionStorage.setItem(key, JSON.stringify(value)), | ||
| } | ||
| return SESSION_STORAGE | ||
| } catch (error) { | ||
| return null | ||
| } | ||
| } |
There was a problem hiding this comment.
I scrapped the factory function here just because it feels simpler for the user to say fcl.storage.default=LOCAL_STORAGE than fcl.storage.default=getLocalStorage() for users. It seems like a bit of an unnecessary abstraction since the object returned is always the same & there's no errors that can occur in the try-catch block anyways.
Happy to reconsider if there's any objections to this however.
nialexsan
approved these changes
Sep 27, 2023
Merged
nialexsan
added a commit
that referenced
this pull request
Oct 31, 2023
This reverts commit 3d037e8.
nialexsan
added a commit
that referenced
this pull request
Oct 31, 2023
nialexsan
added a commit
that referenced
this pull request
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1776